pass ... (= (* 2 2) 4)
pass ... (= (* 3 5) 15)
T
Now imagine that one of the test cases failed and you need to track down the problem. With only five test cases and two test functions, it won't be too hard to find the code of the failing test case. But suppose you had 500 test cases spread across 20 functions. It might be nice if the results told you what function each test case came from.
Since the code that prints the results is centralized in report-result
, you need a way to pass information about what test function you're in to report-result
. You could add a parameter to report-result
to pass this information, but check
, which generates the calls to report-result
, doesn't know what function it's being called from, which means you'd also have to change the way you call check
, passing it an argument that it simply passes onto report- result
.
This is exactly the kind of problem dynamic variables were designed to solve. If you create a dynamic variable that each test function binds to the name of the function before calling check
, then report-result
can use it without check
having to know anything about it.
Step one is to declare the variable at the top level.
(defvar *test-name* nil)
Now you need to make another tiny change to report-result
to include *test- name*
in the FORMAT
output.
(format t '~:[FAIL~;pass~] ... ~a: ~a~%' result *test-name* form)
With those changes, the test functions will still work but will produce the following output because *test-name*
is never rebound:
CL-USER> (test-arithmetic)
pass ... NIL: (= (+ 1 2) 3)
pass ... NIL: (= (+ 1 2 3) 6)
pass ... NIL: (= (+ -1 -3) -4)
pass ... NIL: (= (* 2 2) 4)
pass ... NIL: (= (* 3 5) 15)
T
For the name to be reported properly, you need to change the two test functions.
(defun test-+ ()
(let ((*test-name* 'test-+))
(check
(= (+ 1 2) 3)
(= (+ 1 2 3) 6)
(= (+ -1 -3) -4))))
(defun test-* ()
(let ((*test-name* 'test-*))
(check
(= (* 2 2) 4)
(= (* 3 5) 15))))
Now the results are properly labeled.
CL-USER> (test-arithmetic)
pass ... TEST-+: (= (+ 1 2) 3)
pass ... TEST-+: (= (+ 1 2 3) 6)
pass ... TEST-+: (= (+ -1 -3) -4)
pass ... TEST-*: (= (* 2 2) 4)
pass ... TEST-*: (= (* 3 5) 15)
T
In fixing the test functions, you've introduced several new bits of duplication. Not only does each function have to include the name of the function twice—once as the name in the DEFUN
and once in the binding of *test-name*
—but the same three-line code pattern is duplicated between the two functions. You could remove the duplication simply on the grounds that duplication is bad. But if you look more closely at the root cause of the duplication, you can learn an important lesson about how to use macros.
The reason both these functions start the same way is because they're both test functions. The duplication arises because, at the moment,
Unfortunately, partial abstractions are a crummy tool for building software. Because a half abstraction is expressed in code by a manifestation of the pattern, you're guaranteed to have massive code duplication with all the normal bad consequences that implies for maintainability. More subtly, because the abstraction exists only in the minds of programmers, there's no mechanism to make sure different programmers (or even the same programmer working at different times) actually understand the abstraction the same way. To make a complete abstraction, you need a way to express 'this is a test function' and have all the code required by the pattern be generated for you. In other words, you need a macro.
Because the pattern you're trying to capture is a DEFUN
plus some boilerplate code, you need to write a macro that will expand into a DEFUN
. You'll then use this macro, instead of a plain DEFUN
to define test functions, so it makes sense to call it deftest
.
(defmacro deftest (name parameters &body body)
`(defun ,name ,parameters
(let ((*test-name* ',name))
,@body)))
With this macro you can rewrite test-+
as follows:
(deftest test-+ ()
(check
(= (+ 1 2) 3)
(= (+ 1 2 3) 6)
(= (+ -1 -3) -4)))
Now that you've established test functions as first-class citizens, the question might arise, should test-arithmetic
be a test function? As things stand, it doesn't really matter—if you did define it with deftest
, its binding of *test-name*
would be shadowed by the bindings in test-+
and test-*
before any results are reported.
But now imagine you've got thousands of test cases to organize. The first level of organization is provided by test functions such as test-+
and test-*
that directly call check
. But with thousands of test cases, you'll likely need other levels of organization. Functions such as test-